search

oesmith / ralio

A usable command-line client for Rally
https://github.com/oesmith/ralio
30 stars 21 forks source link

Updated nock to work with node 0.10 #23

Closed aesterline closed 11 years ago

aesterline commented 11 years ago

When running the tests in node 0.10 we got failures that looked like this...

5) Ralio #update should catch Rally operation errors:
     TypeError: Cannot read property 'readable' of undefined
      at IncomingMessage._read (http.js:348:19)
      at IncomingMessage.Readable.read (_stream_readable.js:320:10)
      at IncomingMessage.read (http.js:340:15)
      at IncomingMessage.<anonymous> (_stream_readable.js:735:45)
      at IncomingMessage.EventEmitter.emit (events.js:92:17)
      at emitDataEvents (_stream_readable.js:761:10)
      at IncomingMessage.Readable.on (_stream_readable.js:682:5)
      at OverridenClientRequest.<anonymous> (/Users/aesterline/projects/ralio/node_modules/request/main.js:511:16)
      at OverridenClientRequest.EventEmitter.emit (events.js:95:17)
      at /Users/aesterline/projects/ralio/node_modules/nock/lib/request_overrider.js:206:11
      at process._tickCallback (node.js:415:13)

Updating nock to the latest version removed the test failures and seemed to work with all the other versions of node that are currently supported. I also added the new version of node to the travis ci config.

igorescobar commented 11 years ago

Looks good to me! Thanks @aesterline!

@oesmith any thoughts?

oesmith commented 11 years ago

Perfect! :shipit: