search

oetiker / mrtg

MRTG - Multi Router Traffic Grapher
http://www.mrtg.org
247 stars 61 forks source link

Fix lock and move cache #27

Closed eribertomota closed 2 years ago

eribertomota commented 2 years ago

This is a patch from Debian.

Original name: 010-mrtg_lock_temp_cache_files_fixups.patch URL: https://salsa.debian.org/eriberto/mrtg/-/blob/debian/master/debian/patches/010-mrtg_lock_temp_cache_files_fixups.patch

The headers from this patch are available below:

Description: This patch contains several bugs fixes, f.e. #67327, #41806,

87950, #106415, #206073, #155934 - but given digging so late

         in the past is not easy at all, I wasn't sure to split it further
         (message from Sandro Tosi, 2011-08-15).

Description: Move the mrtg lock files from /etc to /var/lock/mrtg Author: Dermot Bradley bradley@debian.org Bug-Debian: https://bugs.debian.org/41806 Last-Update: 1999-07-26

Description: Fix missing locking code Author: Peter Gervai grin@tolna.net Bug-Debian: https://bugs.debian.org/106415 Last-Update: 2001-07-25

Description: Move MRTG config file cache into /var/lib/mrtg Author: Michael-John Turner mj@debian.org Bug-Debian: https://bugs.debian.org/67327 Last-Update: 2001-09-08

Description: Fix --lock-file option problem Author: Shiju p. Nair shiju@infovillage.net Bug-Debian: https://bugs.debian.org/206073 Last-Update: 2004-02-13

eribertomota commented 2 years ago

Please, keep this PR open. I am learning more about MRTG internals and packaging in Debian. I think I will close this PR soon and send some minor updates to source code (no more changing the rights of the users to run locally, but following the new FHS 3.0). FHS 3.0 was released June 3, 2015.

Thanks.

eribertomota commented 2 years ago

Now I understand some things... In mrtg-2.9.17, when the Debian bug #67327 caused some these changes, options as --fhs did not exist.

oetiker commented 2 years ago

so can we close it now ?

eribertomota commented 2 years ago

so can we close it now ?

Yes. I am doing several tests in Debian and I think I will drop this patch and #30 in Debian too. These changes were made in 2001 and they are deprecated by new options in MRTG. As the new maintainer of MRTG in Debian, I am learning more about the internals of the MRTG to update the packaging.

Note that I need more 1 week from now to send the last patches for some issues that I will find yet. Please, don't release a new version now. Thanks for your patience and very nice work.

Closing this PR, Closes #30.