search

oetiker / rrdtool-1.x

RRDtool 1.x - Round Robin Database
http://www.rrdtool.org
GNU General Public License v2.0
1.01k stars 262 forks source link

no fsync in rrdcached? #1137

Open maurerdietmar opened 2 years ago

maurerdietmar commented 2 years ago

Seems that rrdcached does not make sure that data is written to disk, not even the journal is synced to disk. I am unable to find and calls to fsync, syncfs, fdatasync ...

So I assume that a considerable amount of data can be lost on power failures.

Or do I miss something and data is synced by some other means?

oetiker commented 2 years ago

yes ... if you want things in sync, what is the advantage of rrdcached ?

maurerdietmar commented 2 years ago

1.) we want a cache and journal to speedup read/writes

2.) we do not want to loose any data on power failures (that is whats the journal for (usually))

oetiker commented 2 years ago

yes :) I guess an optional fsync for the journal would be ok :) if you want to PR ...