oetiker / rrdtool-1.x

RRDtool 1.x - Round Robin Database
http://www.rrdtool.org
GNU General Public License v2.0
1.01k stars 262 forks source link

HTML documentation not installed in --htmldir #1178

Open gdsotirov opened 2 years ago

gdsotirov commented 2 years ago

Describe the bug Installation of HTML documentation seems to ignore --htmldir option and files are always installed at /usr/share/doc/rrdtool-x.y.z/html.

To Reproduce Steps to reproduce the behavior:

  1. Configure with ./configure --htmldir=/usr/doc/rrdtool-x.y.z/html;
  2. make and make install;

Expected behavior HTML documentation installed in the directory pointed by --htmldir option.

P.S. There also do not seem to be an option to point the installation location of the files installed under /usr/share/doc/rrdtool-x.y.z/txt.

ferdnyc commented 1 year ago

@gdsotirov

P.S. There also do not seem to be an option to point the installation location of the files installed under /usr/share/doc/rrdtool-x.y.z/txt.

There is, it's just not a flag:

$ ./configure --help
[...]
  RRDDOCDIR   [DATADIR/doc/PACKAGE-VERSION] Documentation directory

The install location of documentation files, including HTML, is based on ${RRDDOCDIR} instead of the usual --docdir path and corresponding subpaths. Can't say I'm sure why, but this:

$ RRDDOCDIR=/tmp/rrdtool ./configure --prefix=/var/tmp/
$ make
$ make install

...Does install the HTML docs in /tmp/rrdtool/html/, and the txt docs in /tmp/rrdtool/txt/.

gdsotirov commented 1 year ago

Thanks for the suggestion @ferdnyc - I'll try it as soon as possible. Anyway, I'd rather prefer to have separate flags for HTML and TXT documentation, so the files could be installed according to each OS recommended paths.