search

oetiker / rrdtool-1.x

RRDtool 1.x - Round Robin Database
http://www.rrdtool.org
GNU General Public License v2.0
1.01k stars 263 forks source link

perl bindings report version that doesn't correspond to rrdtool version #909

Closed az143 closed 5 years ago

az143 commented 6 years ago

as of HEAD at ecf80e and actual overall VERSION showing 1.7.0, $RRDs::VERSION reports itself as 1.5.1 and $RRDp::VERSION 1.4.3. this makes it impossible to determine what rrdtool version you actually do have, at least from within perl.

is that lack of synchronisation just a simple oversight or a design decision, i.e. are the bindings meant to report their internal version only?

vbastos commented 5 years ago

Is there a reason this why this was not accepted? Are the bindings supposed to have their own version?

oetiker commented 5 years ago

this is fixed in 1.7.1

vbastos commented 5 years ago

Why is it still 1.5 in the master branch? Is master not latest stable?

c72578 commented 5 years ago

The version is updated by make dist, which creates the release tarball. See Makefile.am:

dist-hook: VERSION
	$(AM_V_GEN)cd $(distdir) && $(PERL) -i -p -e 's/^\$$VERSION.+/\$$VERSION='$(NUMVERS)';/' bindings/perl-*/*.pm