Notify when a property is not available, and skip to the next dataset.

oetiker / znapzend

zfs backup with remote capabilities and mbuffer integration.

www.znapzend.org

GNU General Public License v3.0

608 stars 137 forks source link

Notify when a property is not available, and skip to the next dataset. #383

Closed flixman closed 5 years ago

flixman commented 5 years ago

When a property on a dataset is not available, znapzend dies with an error message. This PR changes that by a warning and the skipping of that dataset. By doing this, we can set org.znapzend properties on descendant datasets (specifically thinking on the org.znapzend:enable, to skip those datasets that have it set to "off" when coming from a recursive parent).

coveralls commented 5 years ago

Coverage decreased (-0.1%) to 87.5% when pulling 484fdd4df7f211e7be40c6c25b6249ce4f978d67 on flixman:master into 4ccbe714186ac1fbc72a81e0548e6178279b8c76 on oetiker:master.

oetiker commented 5 years ago

sorry missed the context ... getting a warning every time around does not seem all that good a solution either ... since this one property is fine in the context of #154

flixman commented 5 years ago

I am running it right now, and I am only getting a warning when the service is reloaded or started (which is the only moment when the backup plan is refreshed).