search

oetiker / znapzend

zfs backup with remote capabilities and mbuffer integration.
www.znapzend.org
GNU General Public License v3.0
608 stars 137 forks source link

Code review - my $splitHostDataSet differs between Config.pm and ZFS.pm #402

Closed Beneter closed 5 years ago

Beneter commented 5 years ago

The definition of $splitHostDataSet differs between Config.pm and ZFS.pm: https://github.com/oetiker/znapzend/blob/4c758e6b330a0f8b607630a57e9a196fa61863a9/lib/ZnapZend/Config.pm#L34 https://github.com/oetiker/znapzend/blob/4c758e6b330a0f8b607630a57e9a196fa61863a9/lib/ZnapZend/ZFS.pm#L27 Probably both shall be like the definition in ZFS.pm.

@oetiker Is nagging like this appreciated or shall I keep it to myself and PR someday? :-)

oetiker commented 5 years ago

or PR now ... it looks like a good catch :)