search

oetiker / znapzend

zfs backup with remote capabilities and mbuffer integration.
www.znapzend.org
GNU General Public License v3.0
608 stars 137 forks source link

Code review - ZnapZend.pm - Missing underscore #404

Closed Beneter closed 3 years ago

Beneter commented 5 years ago

I am very unsure about this... should dst$key really not be divided by an underscore here (s/dst$key/dst_$key/g)?

https://github.com/oetiker/znapzend/blob/4c758e6b330a0f8b607630a57e9a196fa61863a9/lib/ZnapZend.pm#L182 https://github.com/oetiker/znapzend/blob/4c758e6b330a0f8b607630a57e9a196fa61863a9/lib/ZnapZend.pm#L317-L318

oetiker commented 5 years ago

no, this is a new set of keys being generated they are separate from the dst_..._plan keys ...

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.