Fixes oetiker/znapzend#401 "Code review - destroySnapshots - check that $dataSet is a snapshot before destroying it" - Githubissues

oetiker / znapzend

zfs backup with remote capabilities and mbuffer integration.

www.znapzend.org

GNU General Public License v3.0

608 stars 137 forks source link

Fixes oetiker/znapzend#401 "Code review - destroySnapshots - check that $dataSet is a snapshot before destroying it" #406

Closed Beneter closed 5 years ago

Beneter commented 5 years ago

ZFS.pm destroySnapshots now invokes splitDataSetSnapshot before destroying a snapshot (new: now also in oracle mode). Therefore we are verifying, that we are actually only destorying a snapshot and not the whole file system.

Please double check my escaping :-)

coveralls commented 5 years ago

Coverage increased (+0.009%) to 87.369% when pulling 81780f25a31a1b84a67980cc9b00c154452e5dea on Beneter:fix-issue-401-check-dataset-is-snapshot into 4c758e6b330a0f8b607630a57e9a196fa61863a9 on oetiker:master.

coveralls commented 5 years ago

Coverage increased (+0.009%) to 87.369% when pulling 81780f25a31a1b84a67980cc9b00c154452e5dea on Beneter:fix-issue-401-check-dataset-is-snapshot into 4c758e6b330a0f8b607630a57e9a196fa61863a9 on oetiker:master.

coveralls commented 5 years ago

Coverage increased (+0.009%) to 87.369% when pulling 81780f25a31a1b84a67980cc9b00c154452e5dea on Beneter:fix-issue-401-check-dataset-is-snapshot into 4c758e6b330a0f8b607630a57e9a196fa61863a9 on oetiker:master.

coveralls commented 5 years ago

Coverage increased (+0.009%) to 87.369% when pulling 81780f25a31a1b84a67980cc9b00c154452e5dea on Beneter:fix-issue-401-check-dataset-is-snapshot into 4c758e6b330a0f8b607630a57e9a196fa61863a9 on oetiker:master.

coveralls commented 5 years ago

Coverage increased (+0.009%) to 87.369% when pulling 81780f25a31a1b84a67980cc9b00c154452e5dea on Beneter:fix-issue-401-check-dataset-is-snapshot into 4c758e6b330a0f8b607630a57e9a196fa61863a9 on oetiker:master.

coveralls commented 5 years ago

Coverage increased (+0.009%) to 87.369% when pulling 81780f25a31a1b84a67980cc9b00c154452e5dea on Beneter:fix-issue-401-check-dataset-is-snapshot into 4c758e6b330a0f8b607630a57e9a196fa61863a9 on oetiker:master.

coveralls commented 5 years ago

Coverage increased (+0.009%) to 87.369% when pulling 81780f25a31a1b84a67980cc9b00c154452e5dea on Beneter:fix-issue-401-check-dataset-is-snapshot into 4c758e6b330a0f8b607630a57e9a196fa61863a9 on oetiker:master.