search

oetiker / znapzend

zfs backup with remote capabilities and mbuffer integration.
www.znapzend.org
GNU General Public License v3.0
608 stars 138 forks source link

Fix backup replication of inherited-config datasets #453

Closed jimklimov closed 4 years ago

jimklimov commented 4 years ago

Before this, they were trying to replicate into the original (parent) dst_N rather than into a properly shifted one.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.03%) to 90.066% when pulling b4922a924dcd790a4f3cc65b3b796176e004eafb on jimklimov:send-inherit into 37a001878e69dd91e147ccbf59b5e3b1f86ab6ab on oetiker:master.

jimklimov commented 4 years ago

Note: one failed line of coverage is for the potential error (over-complicated setup) case I am not sure we can hit in current reality, but handle for consistency just in case.

jimklimov commented 4 years ago

@oetiker : I think this one is good to merge :)

oetiker commented 4 years ago

if you request a review, then I know you think the PR is ready ... just click my name in the reviewer list.

jimklimov commented 4 years ago

As not a project member, I don't have a link to click in the Reviewers column ;) So have to CC in comments...

jimklimov commented 4 years ago

Seems good, no not ok and done_ hits found in Travis build logs :)

jimklimov commented 4 years ago

The coverage fault is the same case as above, for displaying an error in the situation we don't really expect to happen IRL.

jimklimov commented 4 years ago

Green and covered (with the conditional-miss above), is there something more to fix here? :)