search

oetiker / znapzend

zfs backup with remote capabilities and mbuffer integration.
www.znapzend.org
GNU General Public License v3.0
607 stars 137 forks source link

Global symbol "$dataSet" requires explicit package name #479

Closed c0deaddict closed 3 years ago

c0deaddict commented 4 years ago

When I'm trying to run the master branch on NixOS I get this warning:

Global symbol "$dataSet" requires explicit package name (did you forget to declare "my $dataSet"?) at /nix/store/rlvxvxa9xayjz623g72awiq96j54ii11-znapzend-0.20.0alpha/lib/ZnapZend/Config.pm line 92.
Compilation failed in require at /nix/store/rlvxvxa9xayjz623g72awiq96j54ii11-znapzend-0.20.0alpha/lib/ZnapZend.pm line 6.
BEGIN failed--compilation aborted at /nix/store/rlvxvxa9xayjz623g72awiq96j54ii11-znapzend-0.20.0alpha/lib/ZnapZend.pm line 6.
Compilation failed in require at /nix/store/rlvxvxa9xayjz623g72awiq96j54ii11-znapzend-0.20.0alpha/bin/znapzend line 9.
BEGIN failed--compilation aborted at /nix/store/rlvxvxa9xayjz623g72awiq96j54ii11-znapzend-0.20.0alpha/bin/znapzend line 9.

Looks like this has been caused by this commit: https://github.com/oetiker/znapzend/commit/60e7afe76ed375c0b3994c29cd2283c02e0f59c4 The GitHub actions annotations are also not happy about this change.

I don't have any experience with Perl, otherwise I would make a PR.

oetiker commented 4 years ago

fix is in pr #480

c0deaddict commented 4 years ago

Nice! Thanks for the very quick response :)

jimklimov commented 4 years ago

Better late than never: "sorry, my bad". Seems like a copypaste issue slipped through, should have been $backupSet->{src} instead of $dataSet that was relevant elsewhere :(

jimklimov commented 3 years ago

Hopefully this is closeable now (or soon after vetting ;) )

c0deaddict commented 3 years ago

Yes, problem is solved and this ticket can be closed :+1: