search

oetiker / znapzend

zfs backup with remote capabilities and mbuffer integration.
www.znapzend.org
GNU General Public License v3.0
604 stars 136 forks source link

Mojo::IOLoop::Delay is no longer needed #584

Closed mtelka closed 1 year ago

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

jimklimov commented 1 year ago

Curious, so it was used (in Perl terms) but not actually used (referenced by code) anymore?

mtelka commented 1 year ago

Curious, so it was used (in Perl terms) but not actually used (referenced by code) anymore?

I think Mojo::IOLoop::Delay was never used explicitly. It was used implicitly by Mojo::IOLoop::ForkCall only.

The use Mojo::IOLoop::Delay line was added to ZFS.pm in Jan 2022 via https://github.com/oetiker/znapzend/commit/492bd16e53a78d893c6f950aefde3a765c09ca7d to solve some warning. But then, in May 2022, the (deprecated) Mojo::IOLoop::ForkCall was replaced by Mojo::IOLoop::Subprocess - see https://github.com/oetiker/znapzend/commit/0a656f75c64cf36a96c1bddb20fa9c6bd50de16b - so Mojo::IOLoop::Delay is no longer used/needed at all.