search

oetiker / znapzend

zfs backup with remote capabilities and mbuffer integration.
www.znapzend.org
GNU General Public License v3.0
604 stars 136 forks source link

Extend `--autoCreation` effect (or default lack thereof) to newly appearing sub-datasets #636

Closed jimklimov closed 2 months ago

jimklimov commented 4 months ago

For example, avoid unexpected creation of avoidably large replicas of root datasets where promotable clones of boot environments are used (currently znapzend makes a new full zfs send, not a clone+promote operation - see #503 and others after it).

Also added a --noautoCreation option to help override configuration file settings (where used), primarily to help test this change locally.

NOTE: I have a nagging feeling that the default value for this setting belongs in ZFS properties (per-destination) rather than in CLI as one toggle to rule them all (can be kept for one-off overrides). Maybe another PR would address that, more so if I get to solving #503 directly. UPDATE: See #637 for zfs props approach.

oetiker commented 3 months ago

I think the zfs aproach #637 is sensible ... do you see benefit in this still ?

jimklimov commented 3 months ago

Somewhat yes. Properties allow for default settings, CLI options for run-time decisions. And this PR allows the latter to be consistent when nested datasets are involved :)