Closed jimklimov closed 2 months ago
See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.
autocreation
@jimklimov the last open pr ... could you have a look at the conflicts?
Cool! :) Yes, thanks. Were the others squashed too, I guess (should have otherwise shared part of history in commit chains IIRC)?
PR source updated to match new master (and effectively to confirm applying its original changes over it).
not squashed :)
Builds on top of #636 ideas and is a step towards #503 hopefully.
At this time some optimization is possible: to only get dataset properties for the source tree once and walk the resulting array of hashes, instead of requesting props many times (once per child dataset as it does here, not unlike the
oracleMode
which trades one-by-onezfs
commands handling vs. memory footprint of querying large chunks of names/properties on very populated ZFS trees). Still, as an MVP, this code already is functional (checked locally).