oetiker / znapzend

zfs backup with remote capabilities and mbuffer integration.
www.znapzend.org
GNU General Public License v3.0
604 stars 136 forks source link

Support `dst_N_autocreation` ZFS properties #637

Closed jimklimov closed 2 months ago

jimklimov commented 4 months ago

Builds on top of #636 ideas and is a step towards #503 hopefully.

At this time some optimization is possible: to only get dataset properties for the source tree once and walk the resulting array of hashes, instead of requesting props many times (once per child dataset as it does here, not unlike the oracleMode which trades one-by-one zfs commands handling vs. memory footprint of querying large chunks of names/properties on very populated ZFS trees). Still, as an MVP, this code already is functional (checked locally).

github-actions[bot] commented 4 months ago

@check-spelling-bot Report jimklimov/znapzend: autoCreation-dstN into -> oetiker/znapzend: 62394b2d8ec788ef19638d27781fcc73b8c3de8b

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (1)

autocreation

Previously acknowledged words that are now absent aix Balert Bcreate Bdebug Bdelete Bedit Berr Bexport Bimport Binfo Bnoaction Bnot Bpidfile Bpost Bpre Bsyslog Bwarning Bzfs Bznapzend Bznapzendzetup Bznapzendztatz CBuilder cpanfile cpanm cpanmin CPANSNAPV crt Cwd cygwin DBD DESTDIR distdir DTDs endif EXTRADIST Fcntl forkcall Icommand Icommon Icreate Idataset Idestroy Idocuments Iexport Ifacility Ifeature Ifilepath Ihome Ilimited imandir Inumber Ioptions Ipath Ipictures Irecursive Isend Iskip Isnapshots Isnapsuffix Isources Itank Ithirdparty Itimeout Iusbbackup Iuser Ivalue Iznapzendzetup JBERGER LEONT lpr Mkbootstrap nobase notest nroff ODBC Pipely RCAPUTO SUBDIRS svcdir troff unicode utf VOS vroff xargs 🫥
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands ... in a clone of the [https://github.com/oetiker/znapzend](https://github.com/oetiker/znapzend) repository on the `master` branch ([:information_source: how do I use this?]( https://github.com/check-spelling/check-spelling/wiki/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' | perl - 'https://github.com/oetiker/znapzend/actions/runs/7836088364/attempts/1' ```
Available :books: dictionaries could cover words (expected and unrecognized) not in the :blue_book: dictionary This includes both **expected items** (656) from .github/workflows//spelling/expect.txt and **unrecognized words** (1) Dictionary | Entries | Covers | Uniquely -|-|-|- [cspell:software-terms/dict/softwareTerms.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/software-terms/dict/softwareTerms.txt)|1288|81|17| [cspell:php/dict/php.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/php/dict/php.txt)|1689|58|6| [cspell:python/src/python/python-lib.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/python/src/python/python-lib.txt)|2417|53|6| [cspell:node/dict/node.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/node/dict/node.txt)|891|56|5| [cspell:filetypes/filetypes.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/filetypes/filetypes.txt)|264|19|4| Consider adding them (in `.github/workflows/spelling.yml`): ``` yml with: extra_dictionaries: cspell:software-terms/dict/softwareTerms.txt cspell:php/dict/php.txt cspell:python/src/python/python-lib.txt cspell:node/dict/node.txt cspell:filetypes/filetypes.txt ``` To stop checking additional dictionaries, add (in `.github/workflows/spelling.yml`): ``` yml check_extra_dictionaries: '' ```
oetiker commented 2 months ago

@jimklimov the last open pr ... could you have a look at the conflicts?

jimklimov commented 2 months ago

Cool! :) Yes, thanks. Were the others squashed too, I guess (should have otherwise shared part of history in commit chains IIRC)?

jimklimov commented 2 months ago

PR source updated to match new master (and effectively to confirm applying its original changes over it).

oetiker commented 2 months ago

not squashed :)