make install does not respect LIBDIR, always installs to LIBDIR/../lib/

spike77453 commented 2 months ago

Since znapzend 0.22.0 make install does not respect LIBDIR any more and tries to install the *.pm files to LIBDIR/.../lib/:

$ ./configure --libdir=/usr/share/perl5/vendor_perl/

```console checking in to see how you are doing... keep fighting man! checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for a race-free mkdir -p... /usr/bin/mkdir -p checking for gawk... gawk checking whether make sets $(MAKE)... yes checking whether make supports nested variables... yes checking whether UID '0' is supported by ustar format... yes checking whether GID '0' is supported by ustar format... yes checking how to create a ustar tar archive... gnutar checking whether to enable maintainer-specific portions of Makefiles... no checking whether make supports nested variables... (cached) yes checking for perl... /usr/bin/perl checking for curl... /usr/bin/curl checking for wget... /usr/bin/wget checking for pod2man... /usr/bin/pod2man checking for rm... /usr/bin/rm checking for CONFIG_YEAR and CONFIG_DATE... got 2024 and 2024-05-03 respectively checking default SMF service name... oep/znapzend checking for way to cat URLs... /usr/bin/wget -O - checking for perl version greater than or equal to 5.16.0... checking is perl reasonably complete... yes. ExtUtils::MakeMaker is available checking if require a c compiler to get perl modules compiled... no checking for grep that handles long lines and -e... /usr/bin/grep checking for gnumake... no checking for gmake... /usr/bin/gmake checking for gnu make availability... /usr/bin/gmake is GNU make checking the price for bergulian eckels... way to expensive! checking for PERL_MODULES... $(top_srcdir)/lib/ZnapZend.pm $(top_srcdir)/lib/ZnapZend/Config.pm $(top_srcdir)/lib/ZnapZend/Time.pm $(top_srcdir)/lib/ZnapZend/ZFS.pm $(top_srcdir)/lib/inheritLevels.pm checking for PERL_CONFIG_VERSION... 5.38 checking for PERL_THIRDPARTY_DIST cache... empty configure: Generating "data" files from templates, see below for executable scripts configure: Generating templated script files that should be marked executable checking that generated files are newer than configure... done configure: creating ./config.status config.status: creating Makefile config.status: creating thirdparty/Makefile config.status: creating lib/Makefile config.status: creating debian/Makefile config.status: creating debian/znapzend.links config.status: creating init/znapzend.service config.status: creating init/znapzend.xml config.status: WARNING: 'init/znapzend.xml.in' seems to ignore the --datarootdir setting config.status: creating init/org.znapzend.plist config.status: creating init/znapzend.freebsd config.status: creating init/znapzend.sysv config.status: creating init/znapzend.upstart ** CONFIGURE DONE ********************************************** Settings: PERL5LIB = not set PERL = /usr/bin/perl SVCINSTALLDIR = no URL_CAT = /usr/bin/wget -O - DEB_BUILD = false The Makefiles should be portable to the best extent of our testing, but their recipes should most certainly succeed with GNU make. It is recommended that now you continue installation with /usr/bin/gmake install ```

$ make
...
$ make install
Making install in lib
make[1]: Entering directory '/tmp/znapzend/znapzend-0.22.0/lib'
make[2]: Entering directory '/tmp/znapzend/znapzend-0.22.0/lib'
make[2]: Nothing to be done for 'install-exec-am'.
 /usr/bin/mkdir -p '/usr/share/perl5/vendor_perl'
 /usr/bin/mkdir -p '/usr/share/perl5/vendor_perl/../lib/ZnapZend'
 /usr/bin/install -c -m 644  ../lib/ZnapZend/Config.pm ../lib/ZnapZend/Time.pm ../lib/ZnapZend/ZFS.pm '/usr/share/perl5/vendor_perl/../lib/ZnapZend'
 /usr/bin/mkdir -p '/usr/share/perl5/vendor_perl/../lib'
 /usr/bin/install -c -m 644  ../lib/ZnapZend.pm ../lib/inheritLevels.pm '/usr/share/perl5/vendor_perl/../lib'
...

git bisect says it was introduced in this commit: https://github.com/oetiker/znapzend/commit/e690f415b68230724bcef4a4d67037df0b42c2a3