oetiker / znapzend

zfs backup with remote capabilities and mbuffer integration.
www.znapzend.org
GNU General Public License v3.0
604 stars 136 forks source link

Fix `make install` of Perl modules with a custom `DESTDIR` and/or `libdir` #652

Closed jimklimov closed 1 month ago

jimklimov commented 1 month ago

Closes: #646 Closes: #651

Checked fixed with GNU Make on Ubuntu 22, illumos make on OpenIndiana, BSD make on FreeBSD 12.

See "screenshot" at https://github.com/oetiker/znapzend/issues/646#issuecomment-2133971445

github-actions[bot] commented 1 month ago

@check-spelling-bot Report jimklimov/znapzend: issue-646 into -> oetiker/znapzend: 23f09232a59ae0b05095cd2840b81b08c7fb2fa9

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors Count
:x: ignored-expect-variant 2

See :x: Event descriptions for more information.

Previously acknowledged words that are now absent Balert Bcreate Bdebug Bdelete Bedit Berr Bexport Bimport Binfo Bnoaction Bnot Bpidfile Bpost Bpre Bsyslog Bwarning Bzfs Bznapzend Bznapzendzetup Bznapzendztatz cpanfile cpanm cpanmin CPANSNAPV crt DBD DESTDIR distdir DTDs endif EXTRADIST forkcall Icommand Icommon Icreate Idataset Idestroy Idocuments Iexport Ifacility Ifeature Ifilepath Ihome Ilimited imandir Inumber Ioptions Ipath Ipictures Irecursive Isend Iskip Isnapshots Isnapsuffix Isources Itank Ithirdparty Itimeout Iusbbackup Iuser Ivalue Iznapzendzetup lpr nobase notest nroff ODBC SUBDIRS svcdir troff unicode utf vroff xargs 🫥
Available :books: dictionaries could cover words (expected and unrecognized) not in the :blue_book: dictionary This includes both **expected items** (668) from .github/workflows//spelling/expect.txt and **unrecognized words** (0) Dictionary | Entries | Covers | Uniquely -|-|-|- [cspell:software-terms/dict/softwareTerms.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/software-terms/dict/softwareTerms.txt)|1288|82|18| [cspell:php/dict/php.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/php/dict/php.txt)|1689|59|6| [cspell:python/src/python/python-lib.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/python/src/python/python-lib.txt)|2417|54|6| [cspell:node/dict/node.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/node/dict/node.txt)|891|58|5| [cspell:filetypes/filetypes.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/filetypes/filetypes.txt)|264|19|4| Consider adding them (in `.github/workflows/spelling.yml`): ``` yml with: extra_dictionaries: cspell:software-terms/dict/softwareTerms.txt cspell:php/dict/php.txt cspell:python/src/python/python-lib.txt cspell:node/dict/node.txt cspell:filetypes/filetypes.txt ``` To stop checking additional dictionaries, add (in `.github/workflows/spelling.yml`): ``` yml check_extra_dictionaries: '' ```
oetiker commented 1 month ago

thanks!

jimklimov commented 1 month ago

Right, thanks for the CHANGES :)

jimklimov commented 1 month ago

For historic note about this fix: it seems that make DESTDIR=... install as the first and only make invocation in the use-case I had here could have been the culprit about not succeeding with cpanm/carton preparation phases (subsequent modules could not find their dependencies in THIRDPARTY_DIR probably), at least greater a problem than parallelism. The former is easy to prove experimentally, the latter less so :)