oetiker / znapzend

zfs backup with remote capabilities and mbuffer integration.
www.znapzend.org
GNU General Public License v3.0
604 stars 136 forks source link

Rename `lib/inheritLevels.pm` to `lib/ZnapZend/InheritLevels.pm`… #655

Closed jimklimov closed 1 month ago

jimklimov commented 1 month ago

…to minimize confusion

From issue #646 discussion follow-up

Needs diligent testing (CI and practical) to make sure the expected inherit functionality is still handled correctly. For local testing to progress, this effort led to PR #654 first, and existing tests did catch some syntax issues that were fixed over a few iterations of this PR's preparation.

github-actions[bot] commented 1 month ago

@check-spelling-bot Report jimklimov/znapzend: issue-646-subdir into -> oetiker/znapzend: a5480d15fe057e3b70c739a757766b27095c5934

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (1)

spamming

Previously acknowledged words that are now absent Balert Bcreate Bdebug Bdelete Bedit Berr Bexport Bimport Binfo Bnoaction Bnot Bpidfile Bpost Bpre Bsyslog Bwarning Bzfs Bznapzend Bznapzendzetup Bznapzendztatz cpanm cpanmin CPANSNAPV crt DBD DESTDIR distdir DTDs endif EXTRADIST forkcall Icommand Icommon Icreate Idataset Idestroy Idocuments Iexport Ifacility Ifeature Ifilepath Ihome Ilimited imandir Inumber Ioptions Ipath Ipictures Irecursive Isend Iskip Isnapshots Isnapsuffix Isources Itank Ithirdparty Itimeout Iusbbackup Iuser Ivalue Iznapzendzetup lpr nobase notest nroff ODBC SUBDIRS svcdir troff unicode utf vroff xargs 🫥
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands ... in a clone of the [https://github.com/oetiker/znapzend](https://github.com/oetiker/znapzend) repository on the `master` branch ([:information_source: how do I use this?]( https://github.com/check-spelling/check-spelling/wiki/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' | perl - 'https://github.com/oetiker/znapzend/actions/runs/9268348164/attempts/1' ```
Available :books: dictionaries could cover words (expected and unrecognized) not in the :blue_book: dictionary This includes both **expected items** (664) from .github/workflows//spelling/expect.txt and **unrecognized words** (1) Dictionary | Entries | Covers | Uniquely -|-|-|- [cspell:software-terms/dict/softwareTerms.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/software-terms/dict/softwareTerms.txt)|1288|82|18| [cspell:php/dict/php.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/php/dict/php.txt)|1689|59|6| [cspell:python/src/python/python-lib.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/python/src/python/python-lib.txt)|2417|54|6| [cspell:node/dict/node.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/node/dict/node.txt)|891|58|5| [cspell:filetypes/filetypes.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/filetypes/filetypes.txt)|264|19|4| Consider adding them (in `.github/workflows/spelling.yml`): ``` yml with: extra_dictionaries: cspell:software-terms/dict/softwareTerms.txt cspell:php/dict/php.txt cspell:python/src/python/python-lib.txt cspell:node/dict/node.txt cspell:filetypes/filetypes.txt ``` To stop checking additional dictionaries, add (in `.github/workflows/spelling.yml`): ``` yml check_extra_dictionaries: '' ```
jimklimov commented 1 month ago

Marked as draft just so that #654 is merged first, and this PR is at least re-checked with those updated recipes before merge. Feel free to un-draft, sync, test and merge after that (and hopeful survival of tests) :)

jimklimov commented 1 month ago

I think new Class syntax is discouraged

I had a suspicion about that - more so after debugging the problems which arose (lack of new method reported). From the times "back when" I remember I've wondered if "class" and "struct" are internally same (syntactic sugar) or different - I think this syntax was copied from some example about structs when I converted from a map 1a925f61 to a struct 8f1f3810 and eventually moved it to a separate file in df23fabe.

And probably it should go with parentheses? e.g. ->new() not plain ->new; (at least per examples I see in other places of the script).

oetiker commented 1 month ago

I think new Class syntax is discouraged

I had a suspicion about that - more so after debugging the problems which arose (lack of new method reported). From the times "back when" I remember I've wondered if "class" and "struct" are internally same (syntactic sugar) or different - I think this syntax was copied from some example about structs when I converted from a map 1a925f6 to a struct 8f1f381 and eventually moved it to a separate file in df23fab.

And probably it should go with parentheses? e.g. ->new() not plain ->new; (at least per examples I see in other places of the script).

the brackets in perl are optional since functions and variables can be distinguished by the presence of a sigil

jimklimov commented 1 month ago

Rebased over recent master and trying the latest suggestion.

jimklimov commented 1 month ago

At least, survived the tests :)