Closed jimklimov closed 1 month ago
See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.
spamming
Marked as draft just so that #654 is merged first, and this PR is at least re-checked with those updated recipes before merge. Feel free to un-draft, sync, test and merge after that (and hopeful survival of tests) :)
I think
new Class
syntax is discouraged
I had a suspicion about that - more so after debugging the problems which arose (lack of new method reported). From the times "back when" I remember I've wondered if "class" and "struct" are internally same (syntactic sugar) or different - I think this syntax was copied from some example about structs when I converted from a map 1a925f61 to a struct 8f1f3810 and eventually moved it to a separate file in df23fabe.
And probably it should go with parentheses? e.g. ->new()
not plain ->new;
(at least per examples I see in other places of the script).
I think
new Class
syntax is discouragedI had a suspicion about that - more so after debugging the problems which arose (lack of new method reported). From the times "back when" I remember I've wondered if "class" and "struct" are internally same (syntactic sugar) or different - I think this syntax was copied from some example about structs when I converted from a map 1a925f6 to a struct 8f1f381 and eventually moved it to a separate file in df23fab.
And probably it should go with parentheses? e.g.
->new()
not plain->new;
(at least per examples I see in other places of the script).
the brackets in perl are optional since functions and variables can be distinguished by the presence of a sigil
Rebased over recent master and trying the latest suggestion.
At least, survived the tests :)
…to minimize confusion
From issue #646 discussion follow-up
Needs diligent testing (CI and practical) to make sure the expected
inherit
functionality is still handled correctly. For local testing to progress, this effort led to PR #654 first, and existing tests did catch some syntax issues that were fixed over a few iterations of this PR's preparation.