search

oeuillot / upnpserver

Fast and light upnp server for node
GNU General Public License v2.0
181 stars 47 forks source link

Better IceCast #30

Closed s-leger closed 9 years ago

s-leger commented 9 years ago

[BUGFIX] _childNamed

oeuillot commented 9 years ago

Ok I can not merge automatically ... So I will merge your work manually ! I will stop working on the master branch if you continue to pull so many work :-)

s-leger commented 9 years ago

I know i’ve messed up something with atom, but have merged upstreams changes by hand. So github won’t merge automagically. too baad.

Maybe we should talk about your intentions so we can coordinate our work.

As a side note, it takes me many time to « understand » your code, and some parts are still « black boxes » to me. eg : find all children nodes of a parent, how to safely destroy a node with refs... Some comments always are welcome in top of methods.

I’ve allready a upnp implementation here, but your base seem better than the one i’m using.

Done some more work on events, to match spec as close as possible, in particular for moderated events.

The main goal is to be able to create other services / devices with this base. So i’m looking for a way to implement generic device and free api from upnpserver.

Le 12 août 2015 à 14:39, Olivier Oeuillot notifications@github.com a écrit :

Ok I can not merge automatically ... So I will merge your work manually ! I will stop working on the master branch if you continue to pull so many work :-)

— Reply to this email directly or view it on GitHub https://github.com/oeuillot/upnpserver/pull/30#issuecomment-130286409.

oeuillot commented 9 years ago

This branch has been merged manualy