search

oeuillot / upnpserver

Fast and light upnp server for node
GNU General Public License v2.0
181 stars 47 forks source link

Target node v4 and ES6 #41

Open oeuillot opened 9 years ago

oeuillot commented 9 years ago

I propose to target NodeJs 4 and ES6 (and discontinue NodeJS v2.x)

An opinion ?

s-leger commented 9 years ago

Why not, should not break anything.

Le 10 sept. 2015 à 10:32, Olivier Oeuillot notifications@github.com a écrit :

I propose to target NodeJs 4 and ES6 (and discontinue NodeJS v2.x)

An opinion ?

— Reply to this email directly or view it on GitHub https://github.com/oeuillot/upnpserver/issues/41.

oeuillot commented 9 years ago

I think so ;-)

And v4 improves performance and memory leaks of Buffer class too !

2015-09-10 10:42 GMT+02:00 s-leger notifications@github.com:

Why not, should not break anything.

Le 10 sept. 2015 à 10:32, Olivier Oeuillot notifications@github.com a écrit :

I propose to target NodeJs 4 and ES6 (and discontinue NodeJS v2.x)

An opinion ?

— Reply to this email directly or view it on GitHub < https://github.com/oeuillot/upnpserver/issues/41>.

— Reply to this email directly or view it on GitHub https://github.com/oeuillot/upnpserver/issues/41#issuecomment-139169203.

oeuillot commented 9 years ago

I have tested v4, and I fixed a little problem ... It seems working !

s-leger commented 9 years ago

Still have to update my node for mac. Pretty cool as should be io.js branch, worried a bit about modules compatibility.

Le 10 sept. 2015 à 13:14, Olivier Oeuillot notifications@github.com a écrit :

I have tested v4, and I fixed a little problem ... It seems working !

— Reply to this email directly or view it on GitHub https://github.com/oeuillot/upnpserver/issues/41#issuecomment-139207038.

oeuillot commented 9 years ago

I have lot of problems, there are several internal asserts which throws Error occasionally ! A nightmare :

assert.js:89
  throw new assert.AssertionError({
  ^
AssertionError: false == true
    at ServerResponse.resOnFinish (_http_server.js:473:7)
    at emitNone (events.js:72:20)
    at ServerResponse.emit (events.js:166:7)
    at finish (_http_outgoing.js:526:10)
    at doNTCallback0 (node.js:407:9)
    at process._tickCallback (node.js:336:13)`
s-leger commented 9 years ago

Sniff Io.js merge is a big step forward, and errors are parts of this game. We have to wait a bit until they address such basic issues. Http server is overused module and many other users are impacted by this. So hope they fix this soon. Wait and see.

Le 11 sept. 2015 à 16:52, Olivier Oeuillot notifications@github.com a écrit :

I have lot of problems, there are several internal asserts which throws Error occasionally ! A nightmare :

assert.js:89 throw new assert.AssertionError({ ^ AssertionError: false == true at ServerResponse.resOnFinish (_http_server.js:473:7) at emitNone (events.js:72:20) at ServerResponse.emit (events.js:166:7) at finish (_http_outgoing.js:526:10) at doNTCallback0 (node.js:407:9) at process._tickCallback (node.js:336:13)`

— Reply to this email directly or view it on GitHub https://github.com/oeuillot/upnpserver/issues/41#issuecomment-139566158.