search

oeuillot / upnpserver

Fast and light upnp server for node
GNU General Public License v2.0
181 stars 47 forks source link

Filter xml attributes #46

Open s-leger opened 8 years ago

s-leger commented 8 years ago

Upnp LastChange event model make a wide use of "val" complex attribute including embedding xml. Xmltojs currently doesn't filter attributes values so we need to escape those manually.

Pushed a pull request on xmltojs. Now wait and see.

oeuillot commented 8 years ago

Is-it the same pull request as you ?

https://github.com/davidcalhoun/jstoxml/pull/9

Good day

s-leger commented 8 years ago

Hi, fix the same problem, but in a more complicated fashion (separated option for attributes).

davidcalhoun/jstoxml#20

oeuillot commented 8 years ago

Yes It is more complicated, but it is older :-p

It seems that I have the same problem in a very huge list of movies.
I don't find where the XML is invalid, because there is only one Android client which detects this problem. The attributes encoding can be the explanation.

So, we can fork it (or copy jstoxml.js into our project), and when the pull request is accepted, we will reference the original implementation in the package.json !?

Olivier

s-leger commented 8 years ago

Go for a patched copy, until either solution was merged. Failure with parsing may also be caused by some special chars in regular text. Got this with a 1500+ movie list from ps3 media server submitted as playlist :) . With such huge list you may also facing with memory limitations issues.