Closed gvanem closed 7 months ago
added a commit that referenced this issue on Nov 6, 2023
I do not see any such change was committed for this file. This code:
+ if (arp->iptable->table[i].dwType == MIB_IPNET_TYPE_INVALID)
+ continue;
is not in master
!? So still Dnet is still broken on Windows.
Not only this, e.g. a dnet ip src 10.0.0.10 dst 10.0.0.1 proto 17
fails due to a missing WSAStartup()
.
There must have been a patch that reverted this change. I'm going to reapply it. Apologies for this, but thanks a lot for spotting and reporting it @gvanem !
Oh. I know what happened. I've only applied this in the devel branch, but that actually reminded me to start working on merging devel back to the default branch and create a new release with the latest fixes.
This is going to be fixed in the next release via https://github.com/ofalk/libdnet/pull/96
Considering this closed with https://github.com/ofalk/libdnet/pull/96/
In
./src/arp-win32.c
,arp_loop()
will add invalid ARP-entries (because of incomplete ARP requests etc.). Was this intentional? It seems strange to do that (comparing to thearp -a
command on Win8.1). The ARP-table now:But after my little patch below, it seems better:
No duplicate. Patch: