Closed kloczek closed 11 months ago
gentle pin 😄
Please have a look at the new branch, where I tried removing the local versions of strl* and strsep: https://github.com/ofalk/libdnet/commit/58d3a7915104bb1d6605c8ddc484fc5951546ca9
Thanks for the ping @kloczek !
Cannot apply that commit on top of master. Do you have maybe some plans to make the new release soon? 🤔
If you are thinking that issue is resolved feel free to close it. I'll retest it on next release. Thx 😃
New release has been created: 1.16 (yes, 1.15 skipped)
Note: Python bindings are currently not really working fine, but that's another story.
There are sill some LTO related warnings. Updated stats for 1.16
Will try to help you with autoconf warnings so you can skipp that part 😄
BTW looks like version in configure.ac has not been updated 😃 https://github.com/ofalk/libdnet/blob/5906d359a179f5d484eb2f77b53bd4b6bf8b0566/configure.ac#L9
Oh crap. monday--
If you could look at the autoconf (beast), that would be awesome!
When sending an MR, please against devel branch. And if I find some time, I'll also look into the issue (again).
I'll try to make few MRs because I see it is much more to clean in ac/am/lt stuff. With few MRs you will have better visibilito what is the propose of exact changes and aprove/reject/discuss in one chunk 😄 I'm not sure but probably it would be good to make next release with corrected version and than we will continue.
Perfect!
I've now added 1.16.1 release: https://github.com/ofalk/libdnet/releases/tag/libdnet-1.16.1
@kloczek do you think you have time to look into this again?
Latest run against the default branch:
# rpmbuild -ba --with check libdnet.spec --quiet 2>&1 | grep -- -W | sed 's/.*\[//; s/\]//' | sort | uniq -c | sort -nr
34 -Wpointer-sign
8 -Wincompatible-pointer-types
2 -Wsizeof-pointer-memaccess
1 -Wunused-variable
1 -Wunused-result
1 -Wunused-function
1 -Wstringop-overflow=
1 -Wmaybe-uninitialized
1 -Wimplicit-function-declaration
1 -Warray-bounds
Since this issue was about LTO, I consider this closed. Thanks again for reporting it @kloczek !
Thx.
At least -Wstringop-overflow=
would be good to fix as well 😋
And -Wunused-variable
, -Wunused-function
are trivial as well 😄
Agree with you @kloczek - it's not like I don't want to address these as well, but not as part of this issue. :-)
Thx for the clarification👍 😄
Summary stats about compile/link time warnings:
Mosts importand are those
-Wlto-type-mismatch
warnings because they are trashing LTO. Here is the full warnings log: