ofek / coincurve

Cross-platform Python bindings for libsecp256k1
https://ofek.dev/coincurve/
Apache License 2.0
153 stars 46 forks source link

Try cibuildwheels on Windows #136

Closed MementoRC closed 9 months ago

MementoRC commented 10 months ago

Attempt to use cibuildwheels on windows to find out - As usual, I don't know what I am doing

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d492d2f) 85.63% compared to head (97bc7bc) 85.86%.

:exclamation: Current head 97bc7bc differs from pull request most recent head cc1c3e0. Consider uploading reports for the commit cc1c3e0 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #136 +/- ## ========================================== + Coverage 85.63% 85.86% +0.22% ========================================== Files 11 11 Lines 564 573 +9 Branches 66 66 ========================================== + Hits 483 492 +9 Misses 45 45 Partials 36 36 ``` | [Files](https://app.codecov.io/gh/ofek/coincurve/pull/136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ofek+Lev) | Coverage Δ | | |---|---|---| | [tests/test\_ecdsa.py](https://app.codecov.io/gh/ofek/coincurve/pull/136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ofek+Lev#diff-dGVzdHMvdGVzdF9lY2RzYS5weQ==) | `100.00% <100.00%> (ø)` | | | [tests/test\_keys.py](https://app.codecov.io/gh/ofek/coincurve/pull/136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ofek+Lev#diff-dGVzdHMvdGVzdF9rZXlzLnB5) | `100.00% <100.00%> (ø)` | | | [tests/test\_utils.py](https://app.codecov.io/gh/ofek/coincurve/pull/136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ofek+Lev#diff-dGVzdHMvdGVzdF91dGlscy5weQ==) | `100.00% <100.00%> (ø)` | |
MementoRC commented 9 months ago

My apologies for this nonsense, it must have been quite obnoxious. I did not realize I could PR against my fork's master and run this ugly fight there. Let me close for now

ofek commented 9 months ago

No worries!