search

ofek / hatch-vcs

Hatch plugin for versioning with your preferred VCS
MIT License
104 stars 15 forks source link

`hatch-vcs` picks up an old version #47

Closed Saransh-cpp closed 1 year ago

Saransh-cpp commented 1 year ago

Thanks for creating this amazing library!

Recently, we accidentally created a liionpack release with the tag v.0.3.4 (which is not compatible with hatch-vcs). The tag was recently renamed to v0.3.4, creating some confusion for git (see how releases and tags are not in sequence, but still, the latest tag is v0.3.7).

https://github.com/pybamm-team/liionpack/pull/270 aims to migrate to hatch-vcs, but for some reason, hatch-vcs keeps on picking up the version v0.3.5 while installing liionpack, whereas, the latest version is v0.3.7.

Could you please let us know where we are going wrong? Thanks!

RonnyPfannschmidt commented 1 year ago

I believe this issue needs to transfer to setuptools-scm

Saransh-cpp commented 1 year ago

Oh yes, that makes sense. I'll shift this. Closing this. Thanks!