search

ofek / hatch-vcs

Hatch plugin for versioning with your preferred VCS
MIT License
110 stars 15 forks source link

Work with setuptools_scm 8.0 (fix #50) #51

Closed musicinmybrain closed 1 year ago

musicinmybrain commented 1 year ago

Make test_write even less brittle (see also #8, #9, #25) so that it works with _version.py files generated by at least setuptools_scm 8.0, 7.1, 7.0, and 6.4.

This is required because setuptools_scm 8.0 added a type-checking comment at the end of the version line.

This is a follow-up to https://github.com/ofek/hatch-vcs/pull/26.

RonnyPfannschmidt commented 1 year ago

@ofek can the ruff job get a own matrix element, the 3.9 failure looks scary else

musicinmybrain commented 1 year ago

With this and https://github.com/ofek/hatch-vcs/pull/26, do you think it’s time to make a 0.3.1 release soon? On one hand, the fixes are only for the tests and don’t affect the correctness of the PyPI wheels. On the other hand, a new release would reduce the number of patches that various distributors need to carry in order to run the tests.

ofek commented 1 year ago

If you have time would you mind fixing the lint errors? After that I can definitely make a release tonight or sometime tomorrow

kloczek commented 1 year ago

IMO it would be good to release new version.