search

ofek / hatch-vcs

Hatch plugin for versioning with your preferred VCS
MIT License
97 stars 15 forks source link

Fix some linter/typechecker findings #54

Closed musicinmybrain closed 10 months ago

musicinmybrain commented 12 months ago

This fixes a few of the things that mypy, ruff, and black were complaining about, as suggested in https://github.com/ofek/hatch-vcs/pull/51#issuecomment-1731758891.

The following complaints from ruff remain:

hatch_vcs/vcs_utils.py:10:36: S603 `subprocess` call: check for execution of untrusted input
tests/utils.py:38:32: S603 `subprocess` call: check for execution of untrusted input

https://docs.astral.sh/ruff/rules/subprocess-without-shell-equals-true/

hatch_vcs/vcs_utils.py:10:36: S607 Starting a process with a partial executable path

https://docs.astral.sh/ruff/rules/start-process-with-partial-path/