Closed effigies closed 10 months ago
Only failure is unrelated linting failures.
Hello, what is the status on this one? :)
Waiting on review. It worked when I wrote it, but I haven't tested against more recent setuptools_scm, if there have been further releases.
Thank you!
It seems more correct to return the actual value (
None
for absent) than a fake value. This will allow us to distinguish the casetemplate = ""
(which setuptools_scm could reasonably treat as an error) from it missing.This patch uses a
sentinel
object to allow the result caching to work withNone
values. Once Python 3.7 is dropped, much of this machinery can be replaced withfunctools.cached_property
.Fixes #49.