search

ofek / hatch-vcs

Hatch plugin for versioning with your preferred VCS
MIT License
109 stars 15 forks source link

Avoid passing an emptry string as the `tag_regex` parameter to `setuptools_scm.get_version` #68

Closed edgarrmondragon closed 4 months ago

edgarrmondragon commented 4 months ago

Closes https://github.com/ofek/hatch-vcs/issues/67

RonnyPfannschmidt commented 4 months ago

@ofek should I apply the necessary changes for tool changes in a separate mr or can this get in whole?

RonnyPfannschmidt commented 4 months ago

@ofek should I apply the necessary changes for tool changes in a separate mr or can this get in whole?

ofek commented 4 months ago

it's fine to do it here I think