search

ofekashery / vertical-stack-in-card

📐 Home Assistant Card: Group multiple cards into a single sleek card.
MIT License
897 stars 79 forks source link

Fix overflow issue #126

Open sdrapha opened 2 years ago

sdrapha commented 2 years ago

Fix drop-down incompatibility with the card Issue #120

ofekashery commented 1 year ago

Thank you, @sdrapha. How does this change affect the border radius? The borderRadius of the inside cards is 0, and removing the overflow: hidden may break the style.

sdrapha commented 1 year ago

I just noticed it now, that is true.

But when I made the PR, 10 months ago, HomeAssistant didn't have rounded corners on the cards, so that was no issue at all.

Althought this is a side-effect in the current homeassistant theme, the benefits of having the input selects in a working state is very important, otherwise I wouldn't use this card at all. I can live with a little point on the corners of some cards, notice it's not all of them, some already have rounded corners as well. And, as last resource, card-mod can fix the issue in each individual iiner card.

Example: image

sdrapha commented 1 year ago

I just pushed a new commit to fix the border radius issue as well

image No sharp corners anymore.

dermotduffy commented 1 year ago

FYI: This also impacts the Frigate card which renders a drop-down menu. That menu may be "cut off" when the overflow is hidden.