search

ofekashery / vertical-stack-in-card

📐 Home Assistant Card: Group multiple cards into a single sleek card.
MIT License
897 stars 79 forks source link

Add UI editor #128

Closed sdrapha closed 2 years ago

sdrapha commented 2 years ago

Add ui-editor by importing the native HA existing editor for vertical and horizontal cards

ThomDietrich commented 2 years ago

How does this one relate to #125 ?

sdrapha commented 2 years ago

How does this one relate to #125 ?

Different aproach, #125 rewrites A LOT of stuff, from scratch, it's even hard to review all that code. (Althought it seems that implements extra new features, which is cool, but I never tested)

This one just pigbacks the already native UI editor from the native Vertical Stack card It's a one line addition in the code, that works!! I've been using it now for months already, so much better to edit cards now...

ThomDietrich commented 2 years ago

Sounds great. Maybe additional features in #125 can be implemented after your PR was merged.

@ofekashery what's blocking this PR?

ofekashery commented 2 years ago

Thanks, @sdrapha!