search

oferh / ng2-completer

Angular 2 autocomplete component
http://oferh.github.io/ng2-completer/
MIT License
347 stars 172 forks source link

Fix package dependencies #288

Closed davidwalschots closed 7 years ago

davidwalschots commented 7 years ago

Some production dependencies were incorrectly located under devDependencies. I noticed this as I was migrating from @angular/http to @angular/common/http in another application.

As a side-note. What are the plans for migration to @angular/common/http within ng2-completer? @angular/common/http requires Angular >= 4.3.0.

oferh commented 7 years ago

@davidwalschots thanks for the PR.

Trying to be backward compatible with Angular as much as possible, so will change to @angular/common/http only if using @angular/http won't be supported.

davidwalschots commented 7 years ago

@oferh OK, understood.

Are there any remarks on the PR?

oferh commented 7 years ago

the PR looks OK to me, will merge it in the next version