search

oferh / ng2-completer

Angular 2 autocomplete component
http://oferh.github.io/ng2-completer/
MIT License
347 stars 172 forks source link

Upgrade to Angular 6 #383

Open karthick-manoharan opened 6 years ago

karthick-manoharan commented 6 years ago

Hello @oferh,

Do you have plans to support Angular 6? Kindly let me know if you are planning or have already started working on the upgrade. I am will to work on the upgrade.

brankoiliccc commented 6 years ago

+1

oferh commented 6 years ago

@karthick-manoharan haven't had time recently to work on it would appricate a PR

hstolzenberg commented 6 years ago

I opened a PR for Angular6 compatibility.

dlwebdev commented 6 years ago

Can you accept his PR for Angular 6?

brankoiliccc commented 6 years ago

Any news on this ?

deepakgoel999 commented 6 years ago

Eagerly looking for update in Angular 6

oferh commented 6 years ago

published as ng2-completer@next

sudhirkumart commented 6 years ago

+ Any update on Angular 6? Eagerly looking for the same.. Thank you!

danielnajeraRTC commented 6 years ago

Might have to use Angular 6's native auto complete. https://www.encodedna.com/angular/autocomplete-textbox-in-angular-6-using-web-api.htm

oferh commented 6 years ago

@danielnajeraRTC that's Material and it's an excellent auto complete solution.

bh-hsi commented 6 years ago

@hstolzenberg @oferh Thanks for the PR and publish - this is saving me a lot of time. However, when making a request to my Express server, the server is returning a 200, but the CompleterService is complaining that it's a 400. I'm digging into the code, but this may be a bug with the PR.

Update: This was an issue on my end. NOTE: Do not use the Ang 6 PR on its own - the RXJS update PR needs to be added as well for full compatibility. I wound up having to make a custom component and remove this library from the project.