RxJS upgrade to v6, plus a few lint corrections.

oferh / ng2-completer

Angular 2 autocomplete component

http://oferh.github.io/ng2-completer/

MIT License

348 stars 173 forks source link

Closed nazrodriguez closed 6 years ago

nazrodriguez commented 6 years ago

Luckily a headache-free, easy migration to an already very popular new version of RxJS. I hope we can agree on that! Regards.

kaichancoder commented 6 years ago

Hi, just wondering when this will be merged? Looking forward to v6. Thanks!

mojoLyon commented 6 years ago

:+1:

SamuelMarks commented 6 years ago

In the meantime @nazrodriguez can you throw in a build to your releases?

Tried:

npm i -S https://api.github.com/repos/nazrodriguez/ng2-completer/tarball/master

But getting these errors:

Can't resolve 'ng2-completer'

Thanks

nazrodriguez commented 6 years ago

@SamuelMarks build uploaded!

Cheers, Naza.

oscarrodar commented 6 years ago

@oferh when will this PR be merged?

Danieltamir commented 6 years ago

@oferh +1 to @oscarrodar

ghost commented 6 years ago

https://github.com/oferh/ng2-completer/issues/404 Will this issue gets fixed by this pull request? Is there a way to use this pull request branch and try it?

stsishkou commented 6 years ago

Dear author, could you merge such branch, in case it is not possible also let know all component consumers

oferh commented 6 years ago

merged to version 3.0.0-beta.2 install by npm install ng2-completer@next