search

oferh / ng2-completer

Angular 2 autocomplete component
http://oferh.github.io/ng2-completer/
MIT License
347 stars 172 forks source link

Chrome browser autocomplete suggestions overlapping ng2-completer suggestions #422

Open nyvio opened 5 years ago

nyvio commented 5 years ago

Hello,

First of all, thanks a lot for developing this very useful component. Recently, we noticed that Chrome browser suggestions (autocomplete) sometimes appeared on top of our remote suggestions. This is of course very annoying. It is not the expected nor intended behaviour.

We really need this issue fixed for our project. I did some digging on the subject and I see how we could fix it. I'm willing to help resolve this issue.

I'll introduce a PR as soon as the solution I have in mind has been tested here. Happy to contribute.

NewteqDeveloper commented 5 years ago

This approach seems to work 100% and fixes the issue 👍 :) thanks @nyvio. I hope the author can pull this in soon

nyvio commented 5 years ago

Thanks for your review @nfourie-work-profile

NewteqDeveloper commented 5 years ago

I am actually still experiencing the same bug even with these changes 😟. It just seems like chrome doesn't care. And it still wants to suggest auto fill based on the provided value

nyvio commented 5 years ago

Hi! Sorry for my late answer. I just tested the solution again, with and without the fix, and it's very clear here that it makes a difference. I'm using Version 73.0.3683.86 of Chrome. Are you maybe using a different version?

NewteqDeveloper commented 5 years ago

Chrome version is identical @ 73.0.3683.86. So the problem that we have is we have multiple of these dropdowns across the system and it seems like it might need to have some different implementation of the autocomplete for each instance. That is my guess, but I haven't had any time to test this out yet on our current project unfortunately. I will hopefully get to it soon and try out that approach.