search

offa / plug

Software for Fender Mustang Amps.
GNU General Public License v3.0
54 stars 20 forks source link

Added Bronco 40 amps, cabinets and effects #21

Open StillVoidingWarranties opened 1 year ago

StillVoidingWarranties commented 1 year ago

I added data for Bronco 40 amps, cabinets and effects as good as I could and it kinda works. However it is quite messy and I broke the tests that require Mustang cabinets.

offa commented 1 year ago

However it is quite messy and I broke the tests that require Mustang cabinets.

Failing tests are ok at the moment. The first step is to figure out whether the device uses a compatible protocol (it seems so :tada:), figure out the ids and getting some working prototype that can do some communication with your device.

Once these are done we can work on the actual implementation, which requires some more work. The bronco dev branch wont get merged directly, but should diff easily to master, so we can follow the changes.

offa commented 1 year ago

Oh and thanks for your PR btw.! :+1:

StillVoidingWarranties commented 1 year ago

I first tried to just append the Bronco amps/cabs/effects but at some places the order seems to matter. Sorry, I'm not very familiar with C++ but I will clean up the code, test it manually and make another PR.

offa commented 1 year ago

I first tried to just append the Bronco amps/cabs/effects but at some places the order seems to matter.

That should happen, but if it does you have found a bug :bug:. Let me know if you need some help here.

Sorry, I'm not very familiar with C++

Really no problem, I can help where needed. Also it might help to do the changes step by step, eg. add amps, test, add cabinets etc.

and make another PR.

You can update this PR, just push commits to your branch.

StillVoidingWarranties commented 1 year ago

Ok, will do.