offbynull / portmapper

Java library that maps ports on NAT-enabled routers (supported protocols: UPnP-IGD/NAT-PMP/PCP).
Apache License 2.0
88 stars 17 forks source link

Port mapping name #30

Open lpetrovic05 opened 7 years ago

lpetrovic05 commented 7 years ago

Currently, when the port mapping is added, it is given a default name "-". Can you add support for custom mapping names?

offbynull commented 7 years ago

Hi,

I can do this but it will only apply to upnpigd. It will require API changes as well as changes to a lot of the parsing tests, so it may take some time.

On Dec 15, 2016 7:51 AM, "lpetrovic05" notifications@github.com wrote:

Currently, when the port mapping is added, it is given a default name "-". Can you add support for custom mapping names?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/offbynull/portmapper/issues/30, or mute the thread https://github.com/notifications/unsubscribe-auth/AGD4IsMNbdIOMLc8tOnY7xH8aF1JMOSQks5rIWHwgaJpZM4LOPxr .

lpetrovic05 commented 7 years ago

Thanks. It's not a must, but it's nice to have.

On Sat, Dec 17, 2016 at 7:46 PM, Kasra Faghihi notifications@github.com wrote:

Hi,

I can do this but it will only apply to upnpigd. It will require API changes as well as changes to a lot of the parsing tests, so it may take some time.

On Dec 15, 2016 7:51 AM, "lpetrovic05" notifications@github.com wrote:

Currently, when the port mapping is added, it is given a default name "-". Can you add support for custom mapping names?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/offbynull/portmapper/issues/30, or mute the thread https://github.com/notifications/unsubscribe-auth/ AGD4IsMNbdIOMLc8tOnY7xH8aF1JMOSQks5rIWHwgaJpZM4LOPxr .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/offbynull/portmapper/issues/30#issuecomment-267779601, or mute the thread https://github.com/notifications/unsubscribe-auth/ATJZCaxxbxVqM6S_jY0YPzxa7iGpVvGNks5rJC33gaJpZM4LOPxr .