search

offbynull / portmapper

Java library that maps ports on NAT-enabled routers (supported protocols: UPnP-IGD/NAT-PMP/PCP).
Apache License 2.0
88 stars 17 forks source link

Automatic module name added #48

Closed hendrikebbers closed 1 year ago

hendrikebbers commented 1 year ago

maven-jar-plugin is used to add "Automatic-Module-Name" to MANIFEST.MF at buildtime. This is the minimum that is needed if you want to use the lib on the module path in a project.

offbynull commented 1 year ago

Do you want me to integrate this change and try cutting a new release? The project is pretty much dead at this point. There's a new version of UPnP-IGD that isn't supported by this library, NAT-PMP is a dead protocol, I'm not sure what's going on with PCP, etc..

hendrikebbers commented 1 year ago

I'm currently working on a project that is still using the lib as a dependency. I will have a look on how it can be replaced but having a release with an "Automatic-Module-Name" would really help me :)

offbynull commented 1 year ago

Alright. I'll see if I can apply this and cut a new release once I get back home (~1 week).

hendrikebbers commented 1 year ago

Hi @offbynull any update?

offbynull commented 1 year ago

Apologies. I have some stuff going on. I'll try to get this out tonight.

offbynull commented 1 year ago

I think this is complete. If correctly done, the new version should show up on Maven central once it syncs (around a day or so IIRC).

offbynull commented 1 year ago

I see it: https://repo1.maven.org/maven2/com/offbynull/portmapper/portmapper/2.0.6/