search

offbyoneBB / mp-onlinevideos2

MediaPortal OnlineVideos Plugin
15 stars 12 forks source link

SearchHistory per Site #42

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Open YouTube, search
2. Escape from search results, do another search
3. Search string is not restored (it's set to "On" in Configuration)

What is the expected output?
Search string should be restored.

What version of the product are you using? On what operating system?
Using r978 on MediaPortal 1.2 Alpha.

Please provide any additional information below.
I presumed logs are not relevant in this case (error.log has nothing, 
MediaPortal.log either. But if you need, I can attach them.

As a side note, after this is fixed, I would much more like to see full search 
history per site. But I can open another request for that later ;)

Thanks!

Original issue reported on code.google.com by mitja.skuver on 1 Nov 2010 at 11:13

GoogleCodeExporter commented 9 years ago 
I cannot confirm this behavior using Blue3Wide and MePo 1.1.1 - it works as 
expected)

A search history as dropdown on the input like you're used from the browser is 
not possible, I don't think the MediaPortal keyboard control supports that.

Original comment by bborgsd...@gmail.com on 1 Nov 2010 at 11:35

GoogleCodeExporter commented 9 years ago 
Perhaps there is something broken in 1.2 then. It would be nice if you find any 
way to test on 1.2 alpha, I will do the same on 1.1/1.1.1 and report :)

Unrelated, I wasn't actually talking about drop down search history in the 
virtual keyboard input (I know that is not possible), but the search history as 
a menu dialog, where the first option would be "New search", other options 
would be X (configurable) last searches on the site. RadioTime plugin works 
this way.

Original comment by mitja.skuver on 1 Nov 2010 at 11:45

GoogleCodeExporter commented 9 years ago 
Hi. Attached is the patch for the extended search history. Together with some 
hint / warning cleanup. Hope you can review it and apply it ;)

As for the original report, even on my second system using 1.2, the text is not 
restored on virtual keyboard. Must be a 1.2 feature, I will take a look soon.

Original comment by mitja.skuver on 2 Nov 2010 at 5:20

Attachments:

GoogleCodeExporter commented 9 years ago 
Another update, I have found the error in the virtual keyboard in 1.2, will be 
fixing it soon. So original issue is not related to OnlineVideos and can be 
closed :)

I can attach the patch in the new issue if you want.

Original comment by mitja.skuver on 2 Nov 2010 at 7:00

GoogleCodeExporter commented 9 years ago 
Yes pls attach I'll review both!

Original comment by bborgsd...@gmail.com on 2 Nov 2010 at 7:30

GoogleCodeExporter commented 9 years ago 
Here is v2 of the patch, with

1) persistent search history per site
2) search history disabled on confirm age sites
3) some refactoring
4) hints / warnings removed only from "internal" sources

Original comment by mitja.skuver on 2 Nov 2010 at 11:52

Attachments:

GoogleCodeExporter commented 9 years ago 
One question:
The VK will popup even when selecting an old search (so I can modify it). Was 
that intended?

Original comment by bborgsd...@gmail.com on 6 Nov 2010 at 5:15

GoogleCodeExporter commented 9 years ago 
Yes it was :) I find it better if I could modify the search any time.. Besides 
it's a click vs. double click :) I can remove if you want..

Original comment by mitja.skuver on 6 Nov 2010 at 8:28

GoogleCodeExporter commented 9 years ago 
Added with http://code.google.com/p/mp-onlinevideos2/source/detail?r=983

Original comment by bborgsd...@gmail.com on 7 Nov 2010 at 12:37