search

offensive-security / nethunter-app

NetHunter android application
314 stars 155 forks source link

Merge changes #195

Closed kimocoder closed 5 years ago

kimocoder commented 5 years ago

Ok... this needs to be reviewed before merging.

kimocoder commented 5 years ago

Think that's all for now.. but this MUST be reviewed before merging.

Re4son commented 5 years ago

Idea to ponder about while I'm testing:

Treble disabled our ability to easily install a user apk through recovery. How about we install the nethunter-app as a system app, place the apks in a persistent directory and then install them during the initial run of nethunter when we set up everything else?

Any thoughts?

kimocoder commented 5 years ago

It's either that, or to use "adb install" externally which also is possible

Re4son commented 5 years ago

I was trying to avoid a tethered install. Another alternative was using a magisk module but then we rely on too many different parts.

The option of "the installer moves the apks to a certain directory if Android >= 8 and the app installs every apk found in that directory during inital setup" looks like the best compromise to me. What do you think?

Re4son commented 5 years ago

On another note: shall we rename the chroot from "kali-armhf" to kali-${ARCH}? It's more for hygiene than practical application right now. Arm64 is complete now and the installer is actually using a proper arm64 chroot in the latest release so we may as well call a spate a spate. How about on arm64 we test for kali-arm64 and fall back to kali-armhf if not found to allow for a new app on a legacy installation?

kimocoder commented 5 years ago

I think so, instead of armhf yes. Sounds good! using adb install would be a primitive solution anyway

kimocoder commented 5 years ago

@Re4son is there anywhere we could communicate? telegram elsn?

Re4son commented 5 years ago

How come?

kimocoder commented 5 years ago

I have to walk through this again, closed but not forgotten 🙂 I had some questions, but I figured it out :+1:

Re4son commented 5 years ago

I'm back on telegram now as @re4son if you want to chat