Passing null to parameter #1 of `round`

officelifehq / officelife

OfficeLife is the first EmpOps platform. It manages everything employees do in a company. From projects to holidays to 1:1s to teams.

https://officelife.io

GNU Affero General Public License v3.0

889 stars 117 forks source link

Passing null to parameter #1 of `round` #1476

Closed elidrissidev closed 2 years ago

elidrissidev commented 2 years ago

If you visit the profile of an employee with no holiday balance (null) while in debug mode, you'll see in the log messages tab of laravel debugbar the following message:

round(): Passing null to parameter #1 ($num) of type int|float is deprecated in app/Models/Company/Employee.php on line 828

This is due to the new change in PHP 8 that deprecates passing null to non-nullable function parameters.

I'll propose a fix soon.

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.