official-antistasi-community / A3-Antistasi

Antistasi Community Version - work in progress - Discord https://discord.com/invite/TYDwCRKnKX
https://antistasi.de
Other
225 stars 156 forks source link

[Feature Request]: Make Antistasi "Drongos Command Enhancement" compatible #3189

Open Celludriel opened 5 months ago

Celludriel commented 5 months ago

Related problem

Drongos Command Enhancement is a great mod to improve handling ai squads. However when used in combination with Antistasi any HC groups at control points garrisons or npc's even petros are added to it's interface. Any of those could be exculded from the DCE mod by a simple line added to the group. Could it be considered to be added ?

Proposed feature

It is possible to exclude a group with _group setVariable["dceExclude",TRUE,TRUE];, not sure where that would need to be in Antistasi's code though.

This should ofcourse only be added to the groups made for things like garrisons and petros. When you order in an infantry squad etc... they should be able to be controlled by the DCE mod

Alternative solutions

Trying out any other mods that improve player squad ai behavior but most are SP only and have some kind of conflict with Antistasi. Open for recommendations for mods that do actually work.

Additional context

No response

Celludriel commented 5 months ago

I'm not entirely sure but I believe it can be achieved by writing a wrapper where hcSetGroup is being called.

image

the places where dce should have control the wrapper wouldn't be used. I'm just contemplating doing this on a fork myself, cause do you actually want to dirty antistasi code with exceptions for another mod ....

Another way of doing it would be to add a variable to groups other mods shouldn't mess with.

_group setVariable ["AntistasiCriticalGroup", true, [true]];

Then other mod authors need to adapt their mods to take antistasi in account

jaj22 commented 5 months ago

I suspect you'd want to avoid adding DCE functionality to the squads with special behaviour (mortar/MG teams, minesweep, minelaying, roadblock creation). Best bet would be to do it on group creation. The only time you'd need to change the variable after that is in addToGarrison.

Celludriel commented 5 months ago

createGroup gave me 58 hits in 40 files. That would need a very fine comb then to figure out where to change it and where not. But does createGroup automatically add it to HC ? I thought another function needed to be used hcSetGroup ?