search

official-antistasi-community / A3-Antistasi

Antistasi Community Version - work in progress - Discord https://discord.com/invite/TYDwCRKnKX
https://antistasi.de
Other
227 stars 154 forks source link

"Send Chat Notification When Downed" QOL Parameter #3400

Open SilenceIsFatto opened 2 months ago

SilenceIsFatto commented 2 months ago

What type of PR is this.

  1. [ ] Bug
  2. [x] Change
  3. [x] Enhancement

What have you changed and why?

Information:

Added a parameter that will send a notification in chat when you are downed/injured.

It helps in cases where players are downed and nobody realises.

Please specify which Issue this PR Resolves.

N/A

Please verify the following and ensure all checks are completed.

  1. [x] Have you loaded the mission in LAN host?
  2. [x] Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. [ ] No
  2. [x] Yes (Please provide further detail below.)

The notification does not trigger with ace medical since fn_handleDamage.sqf exits early if ace medical is present.

I suppose it'd be possible to make it work with ace if the code was replicated in fn_initACEUnconsciousHandler.sqf. Any opinions on that would be appreciated!

Also, if approved localization/translation will need to be added though I'm not entirely sure how that's handled here in Community. I know there will be issues with the message being remoteExec'd after localizing it, not sure if there is a method to handle that yet.

How can the changes be tested?

Steps:

Set the new "Send Chat Notification When Downed" parameter at the bottom of the "Game Mode" parameters to "Yes".

Proceed to be injured and downed, observe the notification appear in the global chat.

Notes:

I can see how the majority might not use this parameter but a few may appreciate it.

jaj22 commented 2 months ago

I'm not really seeing the use case. Text chat is only blocked (well, semi-blocked, there's the escape method) when using ACE medical, correct? So even if you were using TFAR without ACE (which seems kinda unlikely tbh) you could just use the text chat. Players successfully using TFAR and not knowing about text chat seems like an almost impossibly small subset.

SilenceIsFatto commented 2 months ago

The gist of the suggestion that I read for this was basically: Players don't notice the change in injured status because nobody says anything due to tabbing out or doing something else upon being downed.

As I acknowledge in the notes this isn't a very common problem, so it may not be seen as "useful" to most, but it does happen.

The use case would be not having to type it out every single time you are downed and instead have teammates notified immediately with no extra work required on your side (Hence QOL).

If you still think it is pointless then I don't mind closing this pull or having this pull closed.

Bob-Murphy commented 2 months ago

I think that having it in global chat certainly is a bit much. Having it optional in group chat kinda would make more sense than spamming everyone. Also, this is only for players and not AI, correct?

SilenceIsFatto commented 2 months ago

Indeed it is for players. I suppose if players tend to stick with their group it'd make more sense to only notify those who would naturally be closer