Closed jeffli678 closed 7 months ago
I think since we decide to use v4 for uploading, then we should remove "Copy binary to folder" and directly upload the generated binary. Apart from that, the extra file (Wiki, AUTHORS.....) for Android build is not complete, they should be added.
I'm still wondering if it should be better to include the nnue file also in the generated artifacts.
Maybe also add ur name to the AUTHORS file.
I have:
For this, I did not remove the "copy to folder" step because that will cause the binary and nnue file to be put in a folder called "src", which is a bit weird.
I think the structure has to make the binary directly available on the same folder as those files like "README.md". So that's why I suggest removing the "copy to folder" and possibly adding "mv $EXE ../" in "compile xxx build".
I'm still wondering if it should be better to include the nnue file also in the generated artifacts.
Adding the nnue inside the build seems too large. I'm just "wondering" at that time. Maybe it's better to leave the action to produce artifacts w/o it then.
That's pretty much ready for merging.
For this, I did not remove the "copy to folder" step because that will cause the binary and nnue file to be put in a folder called "src", which is a bit weird.
I think the structure has to make the binary directly available on the same folder as those files like "README.md". So that's why I suggest removing the "copy to folder" and possibly adding "mv $EXE ../" in "compile xxx build".
I'm still wondering if it should be better to include the nnue file also in the generated artifacts.
Adding the nnue inside the build seems too large. I'm just "wondering" at that time. Maybe it's better to leave the action to produce artifacts w/o it then.
That's pretty much ready for merging.
I have:
I squashed the commit and prepared it for the merge
Looks good to me.
This PR does two things: