Closed fishchess closed 1 year ago
You posted the engine output in "steps to reproduce"
The new GitHub Issues (Beta) is tricky، Update to Alpha
The template is straightforward. You should provide which commands you used to reach such failure. Engine output is additional information that is usually nice to have if present, but not required.
To assist you to resolve the issue, please give us more detailed information like:
position startpos moves ...
, setoption ...
)Disabling asserts is never a good idea, especially if you don't know what they do and why they are there
no assert triggered here.
Stockfish 15.1 says
info depth 1 seldepth 1 multipv 1 score cp -77 nodes 30 nps 15000 hashfull 0 tbhits 0 time 2 pv c7c5
not
info depth 1 seldepth 1 multipv 1 score cp -21 nodes 28 nps 28000 tbhits 0 time 1 pv b8d7
Instead of making a repo called stockfish and then uploading all of stockfish code you could've just made a fork and committed the differences, avoiding other people the risk of running an unknown exe and most importantly manually diffing the 2 repos (and i really suggest doing this)
the problem is not tied to the piece values and it's not present in the untampered SF code. You broke something when you made your changes to the code, if you are unable to provide a diff of your repo and the SF repo ( you can literally do what i suggested before) the probability of you getting any help is pretty low.
Your exe provided is broken, probably build with Microsoft visual C++, and also the NNUE net is not embedded in the binary, Please mind that to build properly on windows it is probably better to follow these instructions https://github.com/glinscott/fishtest/wiki/Building-Stockfish-on-Windows
Can confirm the issue is not reproducible on a freshly cloned (and correctly compiled) SF repo that only had the knight values changed, with and without nnue being active.
MSVC is not supported. We cannot guaratnee correct compiles with it.
for completeness sake this is the truncated output (made just to show that the engine searches depth 23 without problems) of a correctly compiled SF with FishChess custom values and nnue turned off running on ubuntu 20.04 lts via WSL
Stockfish 15.1 by the Stockfish developers (see AUTHORS file)
setoption name Use NNUE value false
position fen rnbqk1nr/ppp2ppp/4p3/3pP3/3P4/2P5/P1P2PPP/R1BQKBNR b KQkq - 0 5
go depth 23
info string classical evaluation enabled
info depth 1 seldepth 1 multipv 1 score cp -36 nodes 28 nps 28000 hashfull 0 tbhits 0 time 1 pv b8c6
...
info depth 23 seldepth 31 multipv 1 score cp -31 nodes 6075975 nps 718030 hashfull 993 tbhits 0 time 8462 pv g8e7 d1g4 e8f8 g1f3 c7c5 d4c5 d8c7 f1d3 b8d7 e1g1 d7c5 c1a3 b7b6 g4g3 c8d7 c3c4 d5c4 d3c4 f8g8 a1d1 h7h6 a3c5 b6c5 g3f4 e7g6 f4e3 d7c6
bestmove g8e7 ponder d1g4`
Use a different compiler, we don't support MSVC and it has issues.
Please read. https://github.com/official-stockfish/Stockfish/issues/4254#issuecomment-1340146180
Don't make a premature assumption unless you build SF with mingw and get the same result.
OK, so not an issue.
again, use an unmodified master code version, compiled with gcc and see if the issue persists. Otherwise the problem is probably on your side.
MSVC is not supported, unless you follow the recipe here https://github.com/official-stockfish/Stockfish/wiki/Compiling-from-source#microsoft-visual-studio you are almost certain to run in a problem with the toolchain.
@FishChess the code ran fine up to depth 36, furthermore there's no link between an assert on a bitboard and a piece value change and it's highly improbable the two are related. I highly suggest you use a proper fork and learn how to properly compile stockfish
As further proof that the issue isn't reproducible on a correctly compiled version of stockfish this is the truncated output up to depth 40
./Stockfish
Stockfish 15.1 by the Stockfish developers (see AUTHORS file)
setoption name Use NNUE value false
position fen rnbqk1nr/ppp2ppp/4p3/3pP3/3P4/2P5/P1P2PPP/R1BQKBNR b KQkq - 0 5
go depth 40
info string classical evaluation enabled
info depth 1 seldepth 1 multipv 1 score cp -36 nodes 28 nps 28000 hashfull 0 tbhits 0 time 1 pv b8c6
info depth 2 seldepth 2 multipv 1 score cp -36 nodes 107 nps 107000 hashfull 0 tbhits 0 time 1 pv b8c6
...
info depth 40 seldepth 44 multipv 1 score cp -14 nodes 310512059 nps 1895759 hashfull 1000 tbhits 0 time 163793 pv g8e7 d1g4 e8f8 c1a3 b7b6 h2h4 c8a6 f1d3 a6d3 c2d3 b8d7 a3e7 d8e7 g1f3 c7c5 e1g1 c5d4 c3d4 g7g6 a1c1 f8g7 c1c6 h8c8 f1c1 c8c6 c1c6 e7f8 g4f4 a8c8 c6c8
bestmove g8e7 ponder d1g4
Sf 15 Crashed during depth 23 (Sf 15.1 Crashed during depth 26)
The error log :
Assertion failed: count<Pt>(c) == 1, file ..\src\position.h