official-stockfish / Stockfish

A free and strong UCI chess engine
https://stockfishchess.org/
GNU General Public License v3.0
11.59k stars 2.28k forks source link

Small todos from the next dev cycle #5567

Open vondele opened 2 months ago

vondele commented 2 months ago

Describe the issue

Expected behavior

fix above todos.

Steps to reproduce

N/A

Anything else?

N/A

Operating system

All

Stockfish version

master

Disservin commented 2 months ago

Also check if this CI step is really required, https://github.com/official-stockfish/Stockfish/blob/master/.github/workflows/upload_binaries.yml#L40. I have a feeling that the runner already has git and zip, and make shouldnt even be needed.

Disservin commented 2 months ago

Rename the binary stockfish-macos-m1-apple-silicon to just stockfish-macos-apple-silicon since it should support all later processors as well

vondele commented 2 months ago

Rename the binary stockfish-macos-m1-apple-silicon to just stockfish-macos-apple-silicon since it should support all later processors as well

though if we start adding m2, m3 specific optimizations?

Disservin commented 2 months ago

mh fair enough, I guess it should be clear enough that a m1 optimized version will/should also run on all m series chips

cw-sf commented 2 months ago

README.md states "a file with the .nnue extension, storing the neural network for the NNUE evaluation. Binary distributions will have this file embedded.", however my understanding is that Stockfish currently includes a secondary neural network, thus two files.

Also, as spelling change suggestions: the CPW refers to itself as "Chess Programming Wiki" and the big endian architecture is spelled "PowerPC".

Should a separate PR be created for this? If at all, that is.

Disservin commented 2 weeks ago

I've added the help and license to https://github.com/official-stockfish/Stockfish/wiki/UCI-&-Commands#help.