official-stockfish / fishtest

The Stockfish testing framework
https://tests.stockfishchess.org/tests
270 stars 126 forks source link

Fix for #2060. #2061

Closed vdbergh closed 3 weeks ago

ppigazzini commented 3 weeks ago

PROD running with the PR.

vdbergh commented 3 weeks ago

Purging this run gives an exception https://tests.stockfishchess.org/tests/view/666073c7c340c8eed7757c30?show_task=26

vdbergh commented 3 weeks ago

Should be fixed (missing "self.").

ppigazzini commented 3 weeks ago

PROD updated, I added #2059 as well.

vdbergh commented 3 weeks ago

Unfortunately the exception purging https://tests.stockfishchess.org/tests/view/666073c7c340c8eed7757c30?show_task=26 persists :( Can you have a look in the log?

vdbergh commented 3 weeks ago

Found it and fixed it. Coding without testing is really not for me.

ppigazzini commented 3 weeks ago

PROD updated.

vdbergh commented 3 weeks ago

It seems to be working now. I purged https://tests.stockfishchess.org/tests/view/666073c7c340c8eed7757c30 It got games. I stopped it and purged it again. Now it has again gotten games.

vdbergh commented 3 weeks ago

I propose to let it run for while to see if no validation errors appear in the event log.

vdbergh commented 3 weeks ago

The run has stopped by itself now. Things seem fine so far.

ppigazzini commented 3 weeks ago

Logs are clean.