search

official-stockfish / fishtest

The Stockfish testing framework
https://tests.stockfishchess.org/tests
270 stars 126 forks source link

Introduce compute_flags() and validate them. #2069

Closed vdbergh closed 1 week ago

vdbergh commented 2 weeks ago

Previously the flags is_green and is_yellow were derived from formatting information in the result of format_results(run). Obviously this is not nice.

ppigazzini commented 1 week ago

The PR upgrades the run version. I wonder if the new version is compatible with the old one or I need to reload the DB after testing the PR on DEV.

vdbergh commented 1 week ago

Sorry. I went for a walk.

No it is not necessary to change the db. The reason the run version has been raised in this PR is that I made a small change in the algorithm for the color assignment of fixed length runs. But this will not be noticed in practice.

ppigazzini commented 1 week ago

On DEV the PR seems fine, the 2 tests are finished green and red, logs clean. PROD running with the PR.

ppigazzini commented 1 week ago

Thnak you @vdbergh