search

official-stockfish / fishtest

The Stockfish testing framework
https://tests.stockfishchess.org/tests
270 stars 126 forks source link

Partial fix for #2064. #2073

Closed vdbergh closed 2 weeks ago

vdbergh commented 2 weeks ago

I had to sacrifice including base.mak since I do not know how to do it conditionally.

peregrineshahin commented 2 weeks ago

This can be done much cleaner, let me try a fix now that you inspired me how to actually get back the json and make the content type json conditionally.

vdbergh commented 2 weeks ago

The issue is not the content type but the fact that inheriting from base.mak happens unconditionally.

vdbergh commented 2 weeks ago

Anyway I happy to see a better fix.

peregrineshahin commented 2 weeks ago

returning a new Response already escapes the renderer as per how pyramid works

vdbergh commented 2 weeks ago

returning a new Response already escapes the renderer as per how pyramid works

Ah ok! That's much better.

vdbergh commented 2 weeks ago

I will close this, waiting for your PR.