official-stockfish / fishtest

The Stockfish testing framework
https://tests.stockfishchess.org/tests
270 stars 126 forks source link

Make new_run return a string instead of an ObjectId. #2090

Closed vdbergh closed 2 days ago

vdbergh commented 2 days ago

The convention throughout the code base is that run_id is a string.

Since a run_id and the corresponding ObjectId print in exactly the same way, violating this convention may lead to hard to understand bugs such as this one

https://tests.stockfishchess.org/actions?action=log_message&user=&text=internal

which was introduced in #1993.