search

officialchengyud / pe

0 stars 0 forks source link

TutorPro allows duplicate persons with same name and email #5

Open officialchengyud opened 2 months ago

officialchengyud commented 2 months ago

Outline The UG states that TutorPro does not allow duplicate persons. They can have the same name but phone and email must be unique.

Evidence in UG Screenshot 2024-04-19 at 4.47.27 PM.png

What actually happens? It seems that TutorPro actually does not allow people of same names, but allows people of same phone and email. Please see the evidence below.

Why Medium Severity If users don't figure this out themselves, they might not be able to enter any users as TutorPro will block the command actions. The UG and app behaviour are different.

Same name different phone and email: Screenshot See index 9 and my command input.

Screenshot 2024-04-19 at 4.50.52 PM.png

Different name but same phone and email: Screenshot See index 11 and 12.

Screenshot 2024-04-19 at 4.49.57 PM.png

nus-pe-bot commented 2 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

This is actually a documentation bug as it is intended for students to be able to have the same phone number and email. This is because especially for younger students, their point-of-contact might be their parents, and if they have the same point-of-contact, they will have the same phone number and email.

Hence this part is a low severity documentation bug.

For the name part, it is a functionality bug. However, this will not cause a huge inconvenience to the user as they can just add numbering if they happen to have students/parents with the same names, e.g. if there are 3 Jane Does (which is already highly unlikely), they can just save their contact names as Jane Doe 1, Jane Doe 2, and Jane Doe 3.

Hence, this bug with the names is not as important as the work already done in v1.4. Hence, it is a low severity documentation bug.

Items for the Tester to Verify

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your reason]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]